search

near / nearcore

Reference client for NEAR Protocol
https://near.org
GNU General Public License v3.0
2.31k stars 615 forks source link

Fix split storage nayduck test #11276

Open staffik opened 4 months ago

staffik commented 4 months ago 
cargo build -pneard --features test_features,rosetta_rpc &&
cargo build -pgenesis-populate -prestaked -pnear-test-contracts &&
python3 pytest/tests/sanity/split_storage.py

fails on nayduck: https://nayduck.nearone.org/#/test/24068

It is caused by making split storage node a default archival node via changing get_default_kind: https://github.com/near/nearcore/pull/10906/files#diff-7995d7761bfcbeafa61f5b2d4a6b5c2d8ce6587d65385fc4a8efb09e3fd5d724L130-R130

staffik commented 4 months ago

@posvyatokum Do you want to take it over? Or could we have a call so I better understand it to fix it myself?

step1_base_case_test

I changed expected_hot_db_kind to Hot but then get another error:

2024-05-09T16:30:38.047681Z  INFO cold_store: Cold storage population was successful, writing cold head. new_cold_height=0
2024-05-09T16:30:38.047688Z DEBUG cold_store: update HEAD of cold db to 0
2024-05-09T16:30:38.047987Z  INFO cold_store: Moving on. migration_status=SuccessfulMigration
2024-05-09T16:30:38.048040Z  INFO cold_store: Starting the cold store loop
2024-05-09T16:30:38.048153Z ERROR cold_store: cold_store_copy failed error="ColdHeadBehindHotTailError {\n    cold_head_height: 0,\n    hot_tail_height: 21,\n}"

step2_migration_test

_migrate_to_split_storage() calls: neard --home=~/.near/test_migration_2 cold-store prepare-hot --store-relative-path hot_data that fails with exit code 1.