Closed nagisa closed 3 months ago
Attention: Patch coverage is 79.09605%
with 37 lines
in your changes missing coverage. Please review.
Project coverage is 71.45%. Comparing base (
8189888
) to head (4851fce
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
VMLogic
containing a lifetime makes it difficult to have it live for any longer than a short sequence ofinstantiate-link-run
and is one of the reasons why we're forced to have some unsafe code in our linking code.This refactor replaces some of the reference fields with
Arc
s,Box
es, etc. This is not a complete refactor, I intend to do the remainder as a follow-up.Based on #11614 Part of #11319