Closed akashin closed 4 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 71.47%. Comparing base (
3e3137f
) to head (531b147
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
LGTM, I see no reason to reject this.
This being said, I’ll add that I could not find a way to get everything not lack balance at some point while trying to create lots of users. I eventually gave up on using multiple runners, hence the reason why https://github.com/near/nearcore/pull/11560 is suggested to run with a single locust process, which avoids the multiple workers complexity we otherwise have :)
I also had to disable gas price increases under congestion (basically set max_gas_price to min_gas_price) and that was enough for workers to avoid running out of funds.
As they ran out of funds when creating 10M accounts.