Closed wacban closed 3 months ago
Attention: Patch coverage is 88.00000%
with 18 lines
in your changes missing coverage. Please review.
Project coverage is 71.64%. Comparing base (
57c9796
) to head (7d77d69
). Report is 8 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I tested it manually in the following way:
I didn't add any new tests but the dumping logic is at least partially covered by some existing tests. I know because I broke them temporarily while implementing this :).
For completeness I also tested master using the same steps and got the error I was expecting:
thread '<unnamed>' panicked at chain/chain/src/runtime/mod.rs:412:21:
RuntimeError::UnexpectedIntegerOverflow remove_delayed_receipt_gas
stack backtrace:
0: rust_begin_unwind
at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/std/src/panicking.rs:652:5
1: core::panicking::panic_fmt
at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/panicking.rs:72:14
2: near_chain::runtime::NightshadeRuntime::process_state_update::{{closure}}
In you testing, can you consider that the state was dumped using a binary without these changes? Our usecase is that we take an old dump image and generate a genesis from it.
Correctly initialize the congestion info in the genesis chunks. The congestion info needs to be computed based on the state root of each chunk. The boostrapping method is reused for that purpose.
Just to be clear, the congestion info is not stored in the genesis. It is recomputed when the node is started and the genesis is loaded.