codecov[bot]
commented
1 week ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 71.65%. Comparing base (
eb0acac) to head (1759bc4).
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #11664 +/- ## ======================================= Coverage 71.65% 71.65% ======================================= Files 788 788 Lines 161256 161300 +44 Branches 161256 161300 +44 ======================================= + Hits 115541 115574 +33 - Misses 40677 40693 +16 + Partials 5038 5033 -5 ``` | [Flag](https://app.codecov.io/gh/near/nearcore/pull/11664/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | Coverage Δ | | |---|---|---| | [backward-compatibility](https://app.codecov.io/gh/near/nearcore/pull/11664/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `0.23% <ø> (ø)` | | | [db-migration](https://app.codecov.io/gh/near/nearcore/pull/11664/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `0.23% <ø> (ø)` | | | [genesis-check](https://app.codecov.io/gh/near/nearcore/pull/11664/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `1.36% <ø> (ø)` | | | [integration-tests](https://app.codecov.io/gh/near/nearcore/pull/11664/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `37.79% <100.00%> (-0.04%)` | :arrow_down: | | [linux](https://app.codecov.io/gh/near/nearcore/pull/11664/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `69.06% <100.00%> (+0.03%)` | :arrow_up: | | [linux-nightly](https://app.codecov.io/gh/near/nearcore/pull/11664/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `71.12% <100.00%> (-0.01%)` | :arrow_down: | | [macos](https://app.codecov.io/gh/near/nearcore/pull/11664/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `52.64% <ø> (+<0.01%)` | :arrow_up: | | [pytests](https://app.codecov.io/gh/near/nearcore/pull/11664/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `1.59% <ø> (ø)` | | | [sanity-checks](https://app.codecov.io/gh/near/nearcore/pull/11664/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `1.39% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/near/nearcore/pull/11664/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `66.24% <ø> (ø)` | | | [upgradability](https://app.codecov.io/gh/near/nearcore/pull/11664/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `0.28% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Make
parts of generic setup because they are always needed. Additional motivation for warmup - for nayduck tests it happens uncontrollably anyway, because there is always delay between starting nodes and sending first transaction / triggering first event.
After this, existing tests should become compact enough to understand, and new tests can be written, based on them.