Closed jancionear closed 1 week ago
I got stuck in a insta review
loop x,x
Stable wants the snapshot one way, but statelessnet_protocol
wants it the other way (9e0a4de0632964be294f839322e02a65aef06f1e, 4e2d3039c4d00b38804cf936b038b90443110634)
happens because of test_cost_sanity
test: https://github.com/near/nearcore/blob/ea9765f9f91ad4d38cdd4cdfa224b2037c7a19c5/integration-tests/src/tests/runtime/sanity_checks.rs#L95
Attention: Patch coverage is 0%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 71.66%. Comparing base (
48201f8
) to head (e6513e4
). Report is 3 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
core/primitives-core/src/version.rs | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The gas cost of sending receipts between shards is currently too low - it doesn't reflect the limitations caused by network bandwidth. Let's increase the cost of sending a receipt to another account to 50 Tgas / MiB. The increase is low enough so that it shouldn't break any contracts, while still being a big improvement over the previous situation.
Refs: https://github.com/near/nearcore-private/issues/107