search

near / nearcore

Reference client for NEAR Protocol
https://near.org
GNU General Public License v3.0
2.31k stars 605 forks source link

fix: reenable test_full_estimator #11713

Closed jakmeier closed 2 weeks ago

jakmeier commented 2 weeks ago

resolves #11705

Two things needed to be changed.

  1. Copy previous congestion info output over to the next chunk as input.
  2. Disable congestion info to not mess with existing estimations. In particular, DataReceiptCreationPerByte requires large amounts of data to be processed and forwarded every round.
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.74%. Comparing base (b8cf9e5) to head (e7acc39). Report is 1 commits behind head on master.

Files Patch % Lines
.../runtime-params-estimator/src/estimator_context.rs 85.71% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #11713 +/- ## ========================================== + Coverage 70.21% 71.74% +1.52% ========================================== Files 791 791 Lines 161937 161943 +6 Branches 161937 161943 +6 ========================================== + Hits 113711 116192 +2481 + Misses 43265 40716 -2549 - Partials 4961 5035 +74 ``` | [Flag](https://app.codecov.io/gh/near/nearcore/pull/11713/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | Coverage Δ | | |---|---|---| | [backward-compatibility](https://app.codecov.io/gh/near/nearcore/pull/11713/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `0.23% <ø> (ø)` | | | [db-migration](https://app.codecov.io/gh/near/nearcore/pull/11713/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `0.23% <ø> (ø)` | | | [genesis-check](https://app.codecov.io/gh/near/nearcore/pull/11713/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `1.35% <ø> (ø)` | | | [integration-tests](https://app.codecov.io/gh/near/nearcore/pull/11713/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `37.90% <0.00%> (-0.08%)` | :arrow_down: | | [linux](https://app.codecov.io/gh/near/nearcore/pull/11713/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `71.55% <85.71%> (+1.58%)` | :arrow_up: | | [linux-nightly](https://app.codecov.io/gh/near/nearcore/pull/11713/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `71.32% <85.71%> (+1.51%)` | :arrow_up: | | [macos](https://app.codecov.io/gh/near/nearcore/pull/11713/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `54.55% <ø> (+0.06%)` | :arrow_up: | | [pytests](https://app.codecov.io/gh/near/nearcore/pull/11713/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `1.58% <ø> (ø)` | | | [sanity-checks](https://app.codecov.io/gh/near/nearcore/pull/11713/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `1.38% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/near/nearcore/pull/11713/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `66.16% <85.71%> (+1.65%)` | :arrow_up: | | [upgradability](https://app.codecov.io/gh/near/nearcore/pull/11713/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `0.28% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.