search

near / nearcore

Reference client for NEAR Protocol
https://near.org
GNU General Public License v3.0
2.31k stars 605 forks source link

Statelessnet-only: Move versions 68 and 69 back to 80 and 81. #11719

Closed tayfunelmas closed 2 weeks ago

tayfunelmas commented 2 weeks ago

This is on top of the stabilization PR https://github.com/near/nearcore/pull/11701/.

In statelessnet, the genesis version is above 68, so it assumes that genesis has the congestion control is enabled and hitting an issue that attempts to bootstap congestion info (again) and hitting missing state roots.

This change moves the version numbers for congestion control and stateless validation back to 80 and 81 to mitigate the problem. Only merging to statelessnet_master. This should not be merged to mainnet/testnet.

wacban commented 2 weeks ago

btw if you are close to fixing that genesis congestion info bootstrapping it may be easier to just patch that

tayfunelmas commented 2 weeks ago

btw if you are close to fixing that genesis congestion info bootstrapping it may be easier to just patch that

I do not think that will help because it will only work if the bootstrapping happens and saved to DB at the very beginning. For statelessnet, we already passed that point (state roots are already garbage collected).

tayfunelmas commented 2 weeks ago

I am closing this since the failing integration tests are complicating the situation and it is risky to merge this. Instead I will send a simpler PR.