search

near / nearcore

Reference client for NEAR Protocol
https://near.org
GNU General Public License v3.0
2.31k stars 615 forks source link

[ft-benchmark] benchmarknet #11790

Closed MCJOHN974 closed 1 month ago

MCJOHN974 commented 2 months ago

WIP.

This PR aims to add a new chain ID -- benchmarknet, which will be used by ft-benchmark for parameters customization, such that changing storage_proof_size_limit.

aborg-dev commented 2 months ago

WIP.

This PR aims to add a new chain ID -- benchmarknet, which will be used by ft-benchmark for parameters customization, such that changing storage_proof_size_limit.

Have you tested whether this fixes the issue that we were having with storage_proof_size_limit in the benchmark? In my understanding, overwriting the base parameters is not enough, as the diffs that we apply on top will still modify storage_proof_size_limit to the existing mainnet limit. We need to instead modify the last parameters returned by ConfigStore for this chain.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 82.97872% with 8 lines in your changes missing coverage. Please review.

Project coverage is 71.75%. Comparing base (00fbeec) to head (b044cbc). Report is 26 commits behind head on master.

Files Patch % Lines
core/parameters/src/config_store.rs 88.46% 0 Missing and 3 partials :warning:
...me-params-estimator/src/costs_to_runtime_config.rs 0.00% 2 Missing :warning:
chain/indexer/src/streamer/mod.rs 0.00% 1 Missing :warning:
tools/fork-network/src/cli.rs 0.00% 1 Missing :warning:
tools/storage-usage-delta-calculator/src/main.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #11790 +/- ## ========================================== - Coverage 71.78% 71.75% -0.03% ========================================== Files 796 796 Lines 162924 163212 +288 Branches 162924 163212 +288 ========================================== + Hits 116950 117108 +158 - Misses 40922 41051 +129 - Partials 5052 5053 +1 ``` | [Flag](https://app.codecov.io/gh/near/nearcore/pull/11790/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | Coverage Δ | | |---|---|---| | [backward-compatibility](https://app.codecov.io/gh/near/nearcore/pull/11790/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `0.23% <0.00%> (-0.01%)` | :arrow_down: | | [db-migration](https://app.codecov.io/gh/near/nearcore/pull/11790/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `0.23% <0.00%> (-0.01%)` | :arrow_down: | | [genesis-check](https://app.codecov.io/gh/near/nearcore/pull/11790/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `1.35% <0.00%> (-0.01%)` | :arrow_down: | | [integration-tests](https://app.codecov.io/gh/near/nearcore/pull/11790/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `37.83% <14.89%> (-0.08%)` | :arrow_down: | | [linux](https://app.codecov.io/gh/near/nearcore/pull/11790/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `71.37% <82.97%> (+0.06%)` | :arrow_up: | | [linux-nightly](https://app.codecov.io/gh/near/nearcore/pull/11790/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `71.34% <81.81%> (-0.03%)` | :arrow_down: | | [macos](https://app.codecov.io/gh/near/nearcore/pull/11790/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `54.60% <81.08%> (+0.06%)` | :arrow_up: | | [pytests](https://app.codecov.io/gh/near/nearcore/pull/11790/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `1.62% <0.00%> (+0.03%)` | :arrow_up: | | [sanity-checks](https://app.codecov.io/gh/near/nearcore/pull/11790/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `1.42% <0.00%> (+0.03%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/near/nearcore/pull/11790/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `66.20% <80.85%> (-0.01%)` | :arrow_down: | | [upgradability](https://app.codecov.io/gh/near/nearcore/pull/11790/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `0.28% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MCJOHN974 commented 2 months ago

On last commit I made 150 tps on 1m test

MCJOHN974 commented 2 months ago

And 380 tps on 3 min experiment, so just need to prettify it a bit now

MCJOHN974 commented 1 month ago

Last commit produced 390 tps on 3m run as well

MCJOHN974 commented 1 month ago

Migrated to https://github.com/near/nearcore/pull/11826