Closed aborg-dev closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 71.74%. Comparing base (
d7e1232
) to head (35fc1e3
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'm a bit wary of the huge batch size, but the other changes definitely LGTM :)
Yeah, it's optimized for the usage of the existing snapshot (to reduce log spam). Generating one can require some tweaking of settings, but this is done quite rarely.
If the users are already created, we can skip the expensive part of checking each one of them, and instead just populate the array with known accounts.