Closed frolvanya closed 1 month ago
On the one hand, this makes sense. However, If we will send a structure other than Result
Also, we need to make Version
struct pub
, it's not necessarily a bad idea, but it's definetely a small overhead
And process function in the very end will have these ugly raw response builders:
@shreyan-gupta Sorry, it took a bit longer than expected, but I removed Result from process function
Attention: Patch coverage is 51.51515%
with 16 lines
in your changes missing coverage. Please review.
Project coverage is 71.75%. Comparing base (
d7e1232
) to head (f1b8323
). Report is 11 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
chain/jsonrpc/src/lib.rs | 51.51% | 16 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@race-of-sloths please, include my PR in the Race
@frolvanya Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
[
[!IMPORTANT] This pull request is a part of the Race of Sloths and has not been scored yet. Scoring will close in 24 hours! 🕰️
Your contribution is much appreciated with a final score of 0! You have received 0 Sloth points for this contribution
This PR updates the RPC handler to return appropriate HTTP errors for specific RPC issues, improving error visibility for operators
closes #11792