Closed nagisa closed 1 month ago
@nagisa Hey, sorry, I won't have time to review this PR today, I'm going on PTO tomorrow and I'll be gone for a week. Can you find another reviewer or ping me again in a week?
I'll find somebody else, enjoy your time off!
@nagisa Sorry for jumping in, I'd like to invite you to participate in the Race of Sloths. Just mention @race-of-sloths user in your github comment or PR description to join!
See how the flow works here: https://github.com/near/nearcore/pull/11778
@race-of-sloths
@nagisa Thank you for your contribution! Your pull request is now a part of the Race of Sloths! New Sloth joined the Race! Welcome!
[
Attention: Patch coverage is 94.42897%
with 20 lines
in your changes missing coverage. Please review.
Project coverage is 71.80%. Comparing base (
41f6554
) to head (79170bc
). Report is 61 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[!IMPORTANT] This pull request is a part of the Race of Sloths and has not been scored yet. Scoring will close in 24 hours! 🕰️
Your contribution is much appreciated with a final score of 0! You have received 10 (0 base + 10 weekly bonus) Sloth points for this contribution
Another weekly streak completed, well done @nagisa! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths
Best reviewed commit-by-commit.
This ultimately lifts the contract preparation up through a several function call layers in the transaction runtime up to the layer where all the currently necessary data are available.
This PR also establishes in broad strokes where the pipelining decisions will be made (
ApplyProcessingReceiptState
) and makes some minor changes to the type to have it contain local receipts (in addition to the previously contained delayed receipts etc) in a queue of sorts which would allow the pipelining code to look-ahead of the ongoing processing work and queue-up preparation of the upcoming contracts there.This work so far is intended to have no functional changes.
Part of #11319