Closed staffik closed 1 month ago
Attention: Patch coverage is 6.25000%
with 15 lines
in your changes missing coverage. Please review.
Project coverage is 71.78%. Comparing base (
229d287
) to head (4b7da47
). Report is 1 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
chain/client/src/client_actor.rs | 6.25% | 14 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
See https://github.com/near/nearcore/issues/11821 for context.
Check if this is a current validator using current epoch info, not merely the fact that validator key exists.
Testing
Current Mainnet (protocol version 67)
Pre-requirements for the check to kick-in:
tracked_shards=[]
inconfig.json
validator_key.json
existsTested with different validator IDs:
node
- dummy validator ID, it did not crashgritsly.poolv1.near
- existing validator with the lowest stake, not marked asCP
in the debug page, it did not crashsolidstate.poolv1.near
- existing validator with the lowest stake that was marked asCP
in the debug page, it crashedCurrent Testnet (protocol version 69)
Pre-requirements for the check to kick-in:
tracked_shards=[0]
inconfig.json
validator_key.json
existsTested with different validator IDs:
node
- dummy validator ID, it did not crashlavenderfive.pool.f863973.m0
- existing validator with the lowest stake, not marked asCV
in the debug page, it did not crashsnsmlnn.pool.f863973.m0
- existing validator with the lowest stake that was marked asCV
in the debug page, it crashed