Closed pugachAG closed 2 months ago
Attention: Patch coverage is 0%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 71.52%. Comparing base (
0e5e7c7
) to head (442e7d4
).
Files with missing lines | Patch % | Lines |
---|---|---|
core/primitives-core/src/version.rs | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@jancionear thanks for pointing out the test, it actually helped me to discover that I've forgotten to update stable version: 9b94e6793034b5b5221560f3cbb6a919f25a2b60
@jancionear thanks for pointing out the test, it actually helped me to discover that I've forgotten to update stable version: https://github.com/near/nearcore/commit/9b94e6793034b5b5221560f3cbb6a919f25a2b60
Ah right, missed that too. You'll also probably need to update the hashes generated by cargo insta
(?)
Aug 30th status report
This PR changes storage proof soft size limit from 3mb to 4mb. Soft limits defines the value after which we stop executing receipts and move them to the delayed queue. This change addresses the issues on mainnet where we have up to 12% of chunks hitting the size limit. It is worse on shard 5 where it reaches 25%. With this PR we decrease the number of such chunks by ~70%. This change potentially increases the max possible size of state witness, but in practice compressed storage proof doesn't increase much with the current mainnet traffic (
experiment
is 4mb limit andupdate_shard
is 3mb):Also see zulip thread for more context.