codecov[bot]
commented
2 months ago Codecov Report
Attention: Patch coverage is 43.53312% with 179 lines in your changes missing coverage. Please review.
Project coverage is 71.43%. Comparing base (
0e6179a) to head (7e54fdb). Report is 1 commits behind head on master.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #12024 +/- ## ========================================== - Coverage 71.51% 71.43% -0.08% ========================================== Files 814 814 Lines 164513 164774 +261 Branches 164513 164774 +261 ========================================== + Hits 117648 117704 +56 - Misses 41699 41903 +204 - Partials 5166 5167 +1 ``` | [Flag](https://app.codecov.io/gh/near/nearcore/pull/12024/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | Coverage Δ | | |---|---|---| | [backward-compatibility](https://app.codecov.io/gh/near/nearcore/pull/12024/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `0.17% <0.00%> (-0.01%)` | :arrow_down: | | [db-migration](https://app.codecov.io/gh/near/nearcore/pull/12024/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `0.17% <0.00%> (-0.01%)` | :arrow_down: | | [genesis-check](https://app.codecov.io/gh/near/nearcore/pull/12024/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `1.27% <0.00%> (-0.01%)` | :arrow_down: | | [integration-tests](https://app.codecov.io/gh/near/nearcore/pull/12024/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `38.55% <39.74%> (-0.03%)` | :arrow_down: | | [linux](https://app.codecov.io/gh/near/nearcore/pull/12024/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `71.22% <43.53%> (-0.08%)` | :arrow_down: | | [linux-nightly](https://app.codecov.io/gh/near/nearcore/pull/12024/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `71.02% <43.53%> (-0.09%)` | :arrow_down: | | [macos](https://app.codecov.io/gh/near/nearcore/pull/12024/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `54.11% <23.34%> (+0.01%)` | :arrow_up: | | [pytests](https://app.codecov.io/gh/near/nearcore/pull/12024/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `1.54% <0.00%> (-0.01%)` | :arrow_down: | | [sanity-checks](https://app.codecov.io/gh/near/nearcore/pull/12024/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `1.34% <0.00%> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/near/nearcore/pull/12024/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `65.28% <23.34%> (-0.12%)` | :arrow_down: | | [upgradability](https://app.codecov.io/gh/near/nearcore/pull/12024/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `0.21% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Previously we added
ChunkEndorsementBitmaptoBlockInfoto pass the information about which endorsements are received to theEpochManager. We used this in a tool to simulate the validator rewards and kickoffs if we used the received endorsements stats (instead of chunk production stats).In this PR, we complete the picture by adding the bitmap to the
BlockHeader. This bitmap is passed to theBlockInfowhen saving it for theEpochManager. The bitmap is produced directly from the endorsement signatures in theBlockBody, with the same number of shards and chunk validator assignments per shard.We also add validation logic for block body and header. For the block body, we can compare the endorsement signatures to the bitmap values. For the block header, we can compare the length of the bitmap to the number of validator assignments.
NOTE: I am currently reusing
ProtocolFeature::ChunkEndorsementsInBlockHeaderfor the new block header version. And due to some tests assuming that only the last block header version is used, I moved this feature beyond Nightly. Once I can verify the easy mode works, I will send a PR to introduce a separate feature to start usingBlockHeaderV5and in Nightly.