near / nearcore

Reference client for NEAR Protocol
https://near.org
GNU General Public License v3.0
2.32k stars 623 forks source link

rust: 1.81.0 #12053

Closed mina86 closed 1 month ago

mina86 commented 1 month ago

Release notes: https://blog.rust-lang.org/2024/09/05/Rust-1.81.0.html

Addresses the following Clippy warnings:

warning: lint `box_pointers` has been removed: it does not detect
other kinds of allocations, and existed only for historical reasons

warning: struct `PeerComponent` is never constructed
warning: struct `ComponentEdges` is never constructed
warning: struct `LastComponentNonce` is never constructed

warning: this function depends on never type fallback being `()`
   --> core/store/src/trie/shard_tries.rs:468:5
warning: this function depends on never type fallback being `()`
   --> tools/state-viewer/src/state_dump.rs:132:1
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 71.26%. Comparing base (dfe9fcd) to head (9f20c4a).

Files with missing lines Patch % Lines
tools/state-viewer/src/state_dump.rs 0.00% 10 Missing :warning:
core/store/src/trie/shard_tries.rs 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #12053 +/- ## ========================================== - Coverage 71.43% 71.26% -0.17% ========================================== Files 814 814 Lines 164736 164376 -360 Branches 164736 164376 -360 ========================================== - Hits 117685 117150 -535 - Misses 41888 42093 +205 + Partials 5163 5133 -30 ``` | [Flag](https://app.codecov.io/gh/near/nearcore/pull/12053/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | Coverage Δ | | |---|---|---| | [backward-compatibility](https://app.codecov.io/gh/near/nearcore/pull/12053/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `0.17% <0.00%> (+<0.01%)` | :arrow_up: | | [db-migration](https://app.codecov.io/gh/near/nearcore/pull/12053/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `0.17% <0.00%> (+<0.01%)` | :arrow_up: | | [genesis-check](https://app.codecov.io/gh/near/nearcore/pull/12053/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `1.27% <0.00%> (-0.01%)` | :arrow_down: | | [integration-tests](https://app.codecov.io/gh/near/nearcore/pull/12053/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `38.51% <0.00%> (-0.05%)` | :arrow_down: | | [linux](https://app.codecov.io/gh/near/nearcore/pull/12053/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `71.05% <0.00%> (-0.18%)` | :arrow_down: | | [linux-nightly](https://app.codecov.io/gh/near/nearcore/pull/12053/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `70.84% <0.00%> (-0.17%)` | :arrow_down: | | [macos](https://app.codecov.io/gh/near/nearcore/pull/12053/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `53.91% <0.00%> (-0.09%)` | :arrow_down: | | [pytests](https://app.codecov.io/gh/near/nearcore/pull/12053/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `1.54% <0.00%> (-0.01%)` | :arrow_down: | | [sanity-checks](https://app.codecov.io/gh/near/nearcore/pull/12053/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `1.34% <0.00%> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/near/nearcore/pull/12053/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `65.07% <0.00%> (-0.18%)` | :arrow_down: | | [upgradability](https://app.codecov.io/gh/near/nearcore/pull/12053/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `0.21% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

akhi3030 commented 1 month ago

@mooori: are you able to help review this PR please?