near / nearcore

Reference client for NEAR Protocol
https://near.org
GNU General Public License v3.0
2.32k stars 623 forks source link

feat: Update neard init to specify config file type to download #12072

Closed tayfunelmas closed 1 month ago

tayfunelmas commented 1 month ago

We change the --download-config parameter to take a string.

We map the flag to a specific URL containing the config type. The new config files per config type can be found at https://github.com/tayfunelmas/near-configs. The new config files are already uploaded to AWS S3 with the new URLs.

NOTE: For indexer and chainsync-loadtest params, we use rpc config type.

Next: We will update the Near validator documentation to use the new flag value.

Tracking issue: #12070

tayfunelmas commented 1 month ago

Adding @khorolets as reviewer due to the flag change for Indexers.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 21.21212% with 26 lines in your changes missing coverage. Please review.

Project coverage is 71.59%. Comparing base (ea8ec28) to head (511de97). Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
utils/config/src/lib.rs 0.00% 15 Missing :warning:
nearcore/src/config.rs 44.44% 4 Missing and 1 partial :warning:
tools/indexer/example/src/configs.rs 0.00% 3 Missing :warning:
neard/src/cli.rs 50.00% 1 Missing and 1 partial :warning:
tools/chainsync-loadtest/src/main.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #12072 +/- ## ========================================== + Coverage 71.43% 71.59% +0.15% ========================================== Files 815 815 Lines 164218 164279 +61 Branches 164218 164279 +61 ========================================== + Hits 117317 117609 +292 + Misses 41772 41535 -237 - Partials 5129 5135 +6 ``` | [Flag](https://app.codecov.io/gh/near/nearcore/pull/12072/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | Coverage Δ | | |---|---|---| | [backward-compatibility](https://app.codecov.io/gh/near/nearcore/pull/12072/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `0.17% <0.00%> (-0.01%)` | :arrow_down: | | [db-migration](https://app.codecov.io/gh/near/nearcore/pull/12072/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `0.17% <0.00%> (-0.01%)` | :arrow_down: | | [genesis-check](https://app.codecov.io/gh/near/nearcore/pull/12072/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `1.26% <12.00%> (-0.01%)` | :arrow_down: | | [integration-tests](https://app.codecov.io/gh/near/nearcore/pull/12072/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `38.70% <0.00%> (+0.19%)` | :arrow_up: | | [linux](https://app.codecov.io/gh/near/nearcore/pull/12072/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `71.22% <21.21%> (+<0.01%)` | :arrow_up: | | [linux-nightly](https://app.codecov.io/gh/near/nearcore/pull/12072/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `71.13% <15.15%> (+0.11%)` | :arrow_up: | | [macos](https://app.codecov.io/gh/near/nearcore/pull/12072/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `54.07% <12.50%> (+0.06%)` | :arrow_up: | | [pytests](https://app.codecov.io/gh/near/nearcore/pull/12072/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `1.53% <12.00%> (-0.01%)` | :arrow_down: | | [sanity-checks](https://app.codecov.io/gh/near/nearcore/pull/12072/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `1.33% <0.00%> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/near/nearcore/pull/12072/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `65.36% <15.15%> (+0.13%)` | :arrow_up: | | [upgradability](https://app.codecov.io/gh/near/nearcore/pull/12072/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near) | `0.22% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=near#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.