robin-near
commented
2 weeks ago Some things to check for:
- Messing with the proof arbitrarily (flipping every bit perhaps)
- Making a test case where every epoch the block producers change (to check that we don't have any off-by-one errors in verifying handoff and signatures)
Description
Follow-up task to https://github.com/near/nearcore/pull/12020.
Comment: Add some tests (can add some to the testloop test) that messing with the proof will result in a failing verification. We could, e.g. check that tweaking every byte of a valid serialized proof will cause a failure one way or another. It doesn't cover all possible attacks but at least makes sure that we aren't forgetting any fields.