search

near / nearcore

Reference client for NEAR Protocol
https://near.org
GNU General Public License v3.0
2.31k stars 605 forks source link

Create test cover wasmer trap cases #3812

Open ailisp opened 3 years ago

ailisp commented 3 years ago

For wasmer 0.x runner, it's defined in near-vm-errors/src/lib.rs. For wasmer 1.x, it's defined in wasmer/lib/vm/src/trap/trapcode.rs. For both runner, the trap cases are not fully covered in our vm tests and should be.

bowenwang1996 commented 3 years ago

@ailisp what is the status of this issue?

ailisp commented 3 years ago

@bowenwang1996 still need it, don't have update recently

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

bowenwang1996 commented 2 years ago

@matklad do we still need this?

matklad commented 2 years ago

Yes, I am not positive that we have all the tests we need here. I'll assign to @nagisa, as they have better understanding where the combined our+wasmer testing is enough.

nagisa commented 2 years ago

I believe it to be genuinely needed still. The wasmer codebase doesn't seem to have any tests that would test precisely for at least some of the codes, even though they may be fairly straightforward to reproduce. Which also means that it likely doesn't have any tests for tricky corner cases for these codes either.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.