near / nearcore

Reference client for NEAR Protocol
https://near.org
GNU General Public License v3.0
2.32k stars 623 forks source link

Should the runtime host functions validate action inputs before creating the actions? #6444

Open nagisa opened 2 years ago

nagisa commented 2 years ago

Today we validate the contents of receipts and actions before executing them by eventually calling functions like runtime::verifier::validate_receipt, runtime::verifier::validate_action functions.

However, we also apply a similar check when creating some of the actions with the VMLogic host call. But not for others making this behaviour largely inconsistent and quite difficult to understand.

We should either remove all action validity checks from VMLogic or apply the validation consistently by e.g. making it part of the append_action helper.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.