near / nearcore

Reference client for NEAR Protocol
https://near.org
GNU General Public License v3.0
2.33k stars 624 forks source link

Only kickout block / chunk producers if they are lower than threshold compared to the median #9911

Closed gmilescu closed 1 year ago

gmilescu commented 2 years ago

Today we kick out block / chunk producers at the end of the epoch if the number of the blocks / chunk produced is below a certain threshold.

Since we want to set a very aggressive target block production time, some blocks are expected to get slipped. Instead we should kick out any block / chunk producer who produced below the same threshold, but compared to how many blocks / chunks were produced by a median block producer.

In other words, instead of:

kickout = blocks_proudced < total_slots_allocated * threshold && (same for chunks)

we want

let median = blocks_produced_by_median_bp;
kickout = blocks_proudced < block_produced_by_median_bp * threshold && (same for chunks)

ND-54 created by None

gmilescu commented 2 years ago

ilblackdragon commented:

@jimmy3dita Apparently we decided not to do with this for MainNet and will review later.

by 557058:c020323a-70e4-4c07-9ccc-3ad89b1c02ec

gmilescu commented 2 years ago

stefanopepe commented:

Please mention me on the relevant specs, so I can quickly update docs, specs and other material

by 557058:c020323a-70e4-4c07-9ccc-3ad89b1c02ec

gmilescu commented 2 years ago

stale[bot] commented:

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

by 557058:c020323a-70e4-4c07-9ccc-3ad89b1c02ec

gmilescu commented 2 years ago

stale[bot] commented:

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

by 557058:c020323a-70e4-4c07-9ccc-3ad89b1c02ec

gmilescu commented 2 years ago

stale[bot] commented:

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

by 557058:c020323a-70e4-4c07-9ccc-3ad89b1c02ec

gmilescu commented 2 years ago

stale[bot] commented:

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

by 557058:c020323a-70e4-4c07-9ccc-3ad89b1c02ec

gmilescu commented 1 year ago

Closing as duplicate of #2130