search

near / pagoda-relayer-rs

Rust Reference Implementation of Relayer for NEP-366 Meta Transactions
MIT License
32 stars 15 forks source link

Docker Registry #19

Closed volovyks closed 1 year ago

volovyks commented 1 year ago

closes https://github.com/near/pagoda-relayer-rs-fastauth/issues/46

volovyks commented 1 year ago

@anshal-savla I do not have access to this repo. We need to add GCP_CREDENTIALS_DEV to secrets.

itegulov commented 1 year ago

Since this is an open-source repo, I think Docker Hub or GHCR would suit better here

volovyks commented 1 year ago

@anshal-savla now we do not have GCP token. We are using secrets.GITHUB_TOKEN which is considered to be secure. You can read about it here: https://docs.github.com/en/actions/security-guides/automatic-token-authentication But I need you to grant write permission to it: https://github.com/docker/build-push-action/issues/606#issuecomment-1117661805

anshal-savla commented 1 year ago

@volovyks I am not able to change to read and write permission for the actions workflow. @nearlysean Can you help with this?

nearlysean commented 1 year ago

I have a 🚫 no entry icon when trying to change it, as well. image

nearlysean commented 1 year ago

It looks like it needs to be set at the org level first. I'm a little more nervous to make that change at the NEAR org level.

volovyks commented 1 year ago

@nearlysean @anshal-savla we solved this issue, and now it works without extra permissions.

nearlysean commented 1 year ago

Great, thanks for working around it. 👍

anshal-savla commented 1 year ago

@volovyks curious, what was the workaround?

volovyks commented 1 year ago

@anshal-savla GitHub actions could not create a new registry, but it worked once we made it manually. Pushing to it is allowed. @itegulov thanks for the advice.