near / queryapi

Near Indexing as a Service
15 stars 3 forks source link

Feat: Feature toggle for Schema Generation #276

Open roshaans opened 9 months ago

roshaans commented 9 months ago

Schema generation is not supported for all possible schemas, so we will add a feature flag for schema generation until this feature is stable.

pkudinov commented 9 months ago

Do you mean the schema generation for context.db types?

roshaans commented 9 months ago

This does not effect all indexers. Only a select few.

e.g https://near.org/dataplatform.near/widget/QueryApi.App?selectedIndexerPath=roshaan.near/bos_widgets&view=editor-window

image
pkudinov commented 9 months ago

I see. Why do we need a feature flag though? We can just notify a user that this schema is not working and let them proceed. We can change red color to amber. This ticket can be used to track the ability to support this type of DDL

roshaans commented 9 months ago

good idea. I agree that would be a better way to handle this. So i'll just make the error exitable + remove the check for schema generation when the user tries to publish the indexer. One thing to note is that V2 indexer execution will fail because it also depends on this schema generation capabilities.