search

near / rainbow-bridge-sol

10 stars 8 forks source link

Compile solidity contracts are not deterministic #2

Closed ailisp closed 4 years ago

ailisp commented 4 years ago

If compile locally with build.sh and check git status, will see no compiled contracts are changed. But on ci:

https://buildkite.com/nearprotocol/rainbow-bridge-sol/builds/2#c04a013b-2503-49d4-8b2e-afd14e8e019c

a lot of contracts are in "modified" status, means solidity contracts compilation is not deterministic

ailisp commented 4 years ago

I found it's deterministic on linux, and deterministic on mac but there's a trivial difference between mac and linux: (maybe due to difference in version of truffle-flattener?)

image
ailisp commented 4 years ago

It's caused by yarn.lock not commit and truffle-flattener not pinned. Fixed in #1