search

near / wasmtime

Standalone JIT-style runtime for WebAssembly, using Cranelift
https://wasmtime.dev/
Apache License 2.0
3 stars 4 forks source link

Remove unrelated RiscV code from ZK WASM codebase #20

Closed aborg-dev closed 9 months ago

aborg-dev commented 11 months ago 
### Tasks
- [x] `has_zvl*` [extensions](https://github.com/near/wasmtime/blob/056ccdec94f89d00325970d1239429a1b39ec729/cranelift/codegen/src/isa/riscv64/abi.rs#L49C19-L49C32)
- [x] vector registers
- [x] floating point registers
aborg-dev commented 9 months ago

We still have references to Float and Vector registers in the code - I suggest we get rid of them. We still have a reference to RelocDistance::Far, which is not necessary - I suggest we remove it.

nagisa commented 9 months ago

Relocations in general are not going to be necessary in zkasm, we can remove that entire infrastructure entirely.

We still have references to Float and Vector registers in the code - I suggest we get rid of them.

Do we? I thought I removed it all in #48?

aborg-dev commented 9 months ago

I've tried to remove the RelocDistance::Far but it's not yet clear who generates this distance target, so I'm going to leave for now until we encounter it in the wild.