search

near / wasmtime

Standalone JIT-style runtime for WebAssembly, using Cranelift
https://wasmtime.dev/
Apache License 2.0
3 stars 4 forks source link

trying reuse filetests #211

Closed MCJOHN974 closed 7 months ago

MCJOHN974 commented 8 months ago

Just small attempt to reuse some infra from filetests, for example .clif runtests parsing. Not ready to use

MCJOHN974 commented 7 months ago

This PR aims only integrate some code to filetest infrastructure, reuse .clif files parsing, and just to compile some clif to zkasm and print it to stdout. No new checks performed.

It would be followed up by next set of PRs: 1) adding assert as host function to zkasm, such that assert fail don't halt the execution. 2) assembling generated pieces of zkasm to one program 3) final assembling of all previous work together & migrating CI from old version to new version.

MCJOHN974 commented 7 months ago

@akashin, @mooori it's ready for review now.

MCJOHN974 commented 7 months ago

Btw does anybody knows what this failed windows tests telling? I see cranelift\filetests\src\zkasm_runner.rs:117:39: but we even don't have such file... Is this file generated during compilation?..

aborg-dev commented 7 months ago

Btw does anybody knows what this failed windows tests telling? I see cranelift\filetests\src\zkasm_runner.rs:117:39: but we even don't have such file... Is this file generated during compilation?..

Btw does anybody knows what this failed windows tests telling? I see cranelift\filetests\src\zkasm_runner.rs:117:39: but we even don't have such file... Is this file generated during compilation?..

This file was added in https://github.com/near/wasmtime/pull/213 - have you rebased on the latest main branch?

MCJOHN974 commented 7 months ago

Last commit changed structure of test_run_zkasm.rs a lot, and now it builds some .zkasm program from whole test file. It is still WIP, and I left a lot of TODOs, but I think it can be merged as iteration step

MCJOHN974 commented 7 months ago

Last commit fixes review notes (thanks @akashin). Btw, I see that main fails windows tests at zkasm_runner.rs as well, so we just ignore them, am I right?

aborg-dev commented 7 months ago

Last commit fixes review notes (thanks @akashin). Btw, I see that main fails windows tests at zkasm_runner.rs as well, so we just ignore them, am I right?

I'm working on fixing windows tests, but this should not block submitting this PR.

MCJOHN974 commented 7 months ago

Thanks, @mooori, this commit fixes notes you find

MCJOHN974 commented 7 months ago

I'm working on fixing windows tests, but this should not block submitting this PR.

Thanks! I bet merging this PR is not blocking me and we can wait windows tests fix

MCJOHN974 commented 7 months ago

@akashin, now CI is green and all review notes marked as outdated. Should we merge this?