search

near / wasmtime

Standalone JIT-style runtime for WebAssembly, using Cranelift
https://wasmtime.dev/
Apache License 2.0
3 stars 4 forks source link

[Filetests]: Add assert helper function #229

Closed MCJOHN974 closed 4 months ago

MCJOHN974 commented 4 months ago

This PR adds few helper functions: assert_eq, assert_neq, assert_dump. Filetest infra not ready yet, so I didn't change old asserts to new ones. Should I do it before merge or it can be done after? Or I should add .zkasm file somewhere to make testing this helper easy outside my machine?

akashin commented 4 months ago

This PR adds few helper functions: assert_eq, assert_neq, assert_dump. Filetest infra not ready yet, so I didn't change old asserts to new ones. Should I do it before merge or it can be done after? Or I should add .zkasm file somewhere to make testing this helper easy outside my machine?

I would lean towards keeping PRs smaller (so not changing filetests for now), but whatever is convenient to you works.

MCJOHN974 commented 4 months ago

This PR adds few helper functions: assert_eq, assert_neq, assert_dump. Filetest infra not ready yet, so I didn't change old asserts to new ones. Should I do it before merge or it can be done after? Or I should add .zkasm file somewhere to make testing this helper easy outside my machine?

I would lean towards keeping PRs smaller (so not changing filetests for now), but whatever is convenient to you works.

In that case I'm ok to keep this one as is

MCJOHN974 commented 4 months ago

Hm, seems one of the tests is failing due to update of some node packages

akashin commented 4 months ago

Hm, seems one of the tests is failing due to update of some node packages

I think that was a flaky run, rerunning the same test now passes: https://github.com/near/wasmtime/actions/runs/8009020692