Open MCJOHN974 opened 7 months ago
Or maybe even better will be to squash all this fields into just two:
pub struct ExecutionResult {
/// Path to the main zkAsm file that was executed.
path: String,
/// Contains profiling information in case of successful execution and error message
/// if execution failed
counters: Result<Counters, String>
}
Currently
zkasm_runner::ExecutionResult
looks the following way:And I have a few questions about it:
status
isExecutionStatus::Success
, thanerror
containsNone
andcounters
containsSome
?status
isExecutionStatus::RuntimeError
, thanerror
containsSome
andcounters
containsNone
?If answer for both questions above is "yes" does we really need
status
field? It sounds like we already have info about status inerror
andcounters
fields. And, keeping one more such field will need to add extra attention to keep this fields consistent (be sure answer for both questions above is always "yes"). Maybe it will be better to remove this field and add method: