(JS-0057) Found empty functions

nearbeach / NearBeach

NearBeach is an open sourced project management tool, helping you keep track of your project. You can track requirements, projects and tasks

https://nearbeach.org

MIT License

163 stars 64 forks source link

(JS-0057) Found empty functions #488

Open robotichead opened 1 year ago

robotichead commented 1 year ago

Description

Having empty functions hurts readability, and is considered a code-smell. There's almost always a way to avoid using them. If you must use one, consider adding a comment to inform the reader of its purpose.

Occurrences

There are 150 occurrences of this issue in the repository.

See all occurrences on DeepSource → app.deepsource.com/gh/robotichead/NearBeach/issue/JS-0057/occurrences/

DHRUVKHANDELWAL00 commented 1 year ago

hey @robotichead , i would like to work on it. please assign me

robotichead commented 1 year ago

This issue requires placing in the ErrorModalMixin, as that will handle what to do when an error occurs. We can't remove these functions - just finally populate them with instructions.