search

nearby-sharing / android

Share files between android and PC via the Windows 10 / 11 built-in sharing functionality (Project Rome)
https://nearshare.shortdev.de
GNU General Public License v3.0
646 stars 33 forks source link

Dynamic size of `PresenceResponse` #140

Closed ShortDevelopment closed 3 months ago

ShortDevelopment commented 3 months ago

PresenceResponse is currently using a hard-coded length but is dynamic in size (it contains the device name). https://github.com/nearby-sharing/android/blob/4e05e07e0a26c421962394fdf0421c8831bf74b3/lib/ShortDev.Microsoft.ConnectedDevices/Transports/NetworkTransport.cs#L191-L200

Therefore this message can't be parsed by other devices and receiving is not possible.

See https://github.com/nearby-sharing/cli/issues/1#issuecomment-1614189387

@electr1fy0