nearby-sharing / android

Share files between android and PC via the Windows 10 / 11 built-in sharing functionality (Project Rome)
https://nearshare.shortdev.de
GNU General Public License v3.0
647 stars 33 forks source link

Can't send large files #93

Closed WXZhao7 closed 10 months ago

WXZhao7 commented 1 year ago

Wow, I found a treasure! I installed the beta version, and everything worked except sending the file larger than ~250Mb. Here is my screen recording.

https://github.com/ShortDevelopment/Nearby-Sharing-Windows/assets/56864878/ef5ab4af-c73e-4703-b735-1d754b8756ad

Another confusing thing is the default receive path. The file stored at /storage/emulated/0/Android/media/de.shortdev.nearby_sharing_windows/Download/ not friendly for user. I guess this just a beta/test setting:)

WXZhao7 commented 1 year ago

This version v1.3.3-beta not contain this issue.

ShortDevelopment commented 1 year ago

That's likely doe to the custom send implementation (#21) I've added in v1.4.0. I'll have a look; Thank you!

ShortDevelopment commented 11 months ago

ReadAsync might return before reading all bytes! https://github.com/nearby-sharing/android/blob/8e641fe6773d02290aeffe150ff8105529fa463f/Nearby%20Sharing%20Windows/SendActivity.cs#L166-L167