search

nearform / cypress-setup

Accelerator to speed up Cypress testing
0 stars 0 forks source link

Add the ability to run with docker-compose #25

Closed gregoryduckworth closed 2 years ago

gregoryduckworth commented 2 years ago

If we add the ability to run through docker-compose, we should be able to more easily integrate with CI/CD pipelines.

simoneb commented 2 years ago

In GitHub they have already an action which is very easy to use and doesn't require using containers explicitly. We're using it in techbase. https://github.com/nearform/techbase/blob/master/.github/workflows/ci.yml#L66

gregoryduckworth commented 2 years ago

This is true but not all of our clients have the ability to use the cypress-io Github actions, so providing a mechanism to still use it as part of a pipeline is still a worthy endeavour.

sathish-paramasivam commented 2 years ago

PR has been approved https://github.com/nearform/cypress-setup/pull/51 and merged. Can I move this ticket to Done? pls let me know, thanks

simoneb commented 2 years ago

@sathish-paramasivam if you link a PR to an issue, the issue will be closed automatically when the PR is merged. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

sathish-paramasivam commented 2 years ago

Got it! thanks