search

nearform / playwright-firebase

A plugin to handle Firebase authentication in Playwright tests
Other
19 stars 3 forks source link

Flaky signin: Cannot read properties of undefined (reading 'getApps' #180

Closed borisyordanov closed 9 months ago

borisyordanov commented 11 months ago

A lot of the time the package is working, but occasionally it fails. It appears that getApps() is run before the firebase scripts are inserted in the dom and evaluted.

image

vikasbhandari2 commented 10 months ago

Thanks for reporting!

Can you provide steps to reproduce? We often need a reproducible example, e.g. some code that allows someone else to recreate your problem by just copying and pasting it. If it involves more than a couple of different file, create a new repository on GitHub and add a link to that.

Ademsk1 commented 10 months ago

Agreed with @vikasbhandari2 . Would be interested to know if you're passing through a specific version of Firebase as well.

borisyordanov commented 10 months ago

Unfortunately, this one is very sporadic - it doesn't happen in a specific test. On some runs it doesn't happen at all. Thankfully playwright's auto-retry helps make this bug something we can live with.

We're using firebase@10.5.2, but upgrading to 10.7.2 didn't solve the issue.

Are you sure that when you try to get the firebase app the script is inserted and that the cdn has sent the code over? There might be a race condition.

github-actions[bot] commented 3 months ago

🎉 This issue has been resolved in version 1.2.9 🎉

The release is available on: