search

nearform / react-pwa

Hackernews Progressive Web Application built with React
https://hackernews.nearform.com
27 stars 14 forks source link

Generate manifest files to make use of theme configuration #54

Closed fromflux closed 6 years ago

fromflux commented 6 years ago

Currently the manifest is a static file with hard coded colour values. This could become an issue when updating the theme since it can result in a mismatch if the manifest is missed. The manifest file should be generated at build time (appropriate if the theme does not change between builds) using the theme configuration. To consider: What would the solution be if the theme needs to change between builds (is it possible to trigger a manifest refresh from the client)? Is that a better solution?

fromflux commented 6 years ago

Another point: In case of white label applications (a theme per client or even user) is there an appropriate solution?