nearform / titus

Deploy useful features in sprint one
https://nf-titus.netlify.app
Apache License 2.0
61 stars 43 forks source link

Storybook fails to start locally #1472

Closed noodny closed 2 years ago

noodny commented 2 years ago

This came up while working on https://github.com/nearform/titus/pull/1471.

Storybook fails to start due to a bug in a release of react-refresh, which is being used by @storybook/preset-create-react-app. Due to a fix not being published for a couple of months, the most reasonable way to use the fixed version is to update react-scripts to 5.0. This will however require storybook itself to be updated.

TLDR - update everything that's storybook related

Eomm commented 2 years ago

Sidenote: updating react-scripts to 5, should unblock #923: now the installation fails due d conflict generated by react-scripts@4

simoneb commented 2 years ago

@Eomm I tried to do it a few days ago on a PR that dependabot had opened and I wished I hadn't tried. I found myself in a vale of tears