Context policy variable evaluation

nearform / udaru

Open source Access Manager for node.js

https://nearform.github.io/udaru

MIT License

124 stars 19 forks source link

Context policy variable evaluation #500

Closed cianfoley-nearform closed 6 years ago

cianfoley-nearform commented 6 years ago

@dberesford @mihaidma

I rebased this branch with master, the context stuff is in here and I added some testing around it, as well as tests around not allowing reserved keywords as variable names in policy instances.

Volume db and autocannon volume tests can be run now from hapi-server-plugin module too.

coveralls commented 6 years ago

Coverage decreased (-0.09%) to 94.126% when pulling b02ba6eb680e015d6acf16fb2465bd05893fe922 on context-policy-variable-evaluation into 5745ca0f5834b0369f532329f81afa64888ed4c0 on master.

mihaidma commented 6 years ago

@cianfoley-nearform not exactly the main target of this pr but should we also have an e2e test showing the usage of conditionals for org for example?

cianfoley-nearform commented 6 years ago

@mihaidma @dberesford, thanks for reviews, I made some updates based on comments:

added ip context to 2 other functions in authorize (added extra context variable called request.source, which is set to 'server' if IP address is present, otherwise it's set to 'api')
added some documentation for the variables in the core documentation
added some documentation for the volume and bench in the udaru-hapi-server documentation
extra tests in core and server around IP address and other things

mihaidma commented 6 years ago

@cianfoley-nearform LGTM