nearform / udaru

Open source Access Manager for node.js
https://nearform.github.io/udaru
MIT License
124 stars 19 forks source link

hapi-auth-udaru package #505

Closed ShogunPanda closed 6 years ago

ShogunPanda commented 6 years ago

Fixes #501.

In order to maintain both v16 and v17 packages I created a new package called hapi-auth-udaru that contains both udaru-hapi-plugin and udaru-hapi-server as a single package.

The code has been slightly reorganized and simplified. Test coverage is 100%.

The udaru-core has been modified to support async/await, but its still compatible with hapi v16.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 93.136% when pulling 6fce4db3973c533a2657c76a7c11bc18805e690d on hapi-auth-udaru into 81855ca5c826d38b1c9eda979a194456f33565b6 on master.

ShogunPanda commented 6 years ago

Note: this is currently base after #508. Make sure to wait for it to be merged, then rebase after master before merging.

ShogunPanda commented 6 years ago

@mcollina Due to force push, I can't see your previous Travis commit. But I can confirm is now run on 6 and 8.9

ShogunPanda commented 6 years ago

@mcollina The new name for the new package is because udaru-hapi-* will be for v16-, while hapi-auth-udaru (which contains both) is for v17+. I picked up a new name trying to be consistent with other plugins in the Hapi plugins list.

mcollina commented 6 years ago

yes I much preferred the old naming convention, I know it's not hapi convention but I don't care. Am leaning back towards:

udaru-core
udaru-hapi-16-plugin
udaru-hapi-plugin
udaru-hapi-server

I like this.

mcollina commented 6 years ago

I would recommend to ship https://www.npmjs.com/package/swagger-ui-dist instead of copying the files of swagger ui. It can be a separate issue, but I see the files are being moved around in this PR.

ShogunPanda commented 6 years ago

I've update the package names as @dberesford asked. udaru-hapi-server now runs on udaru-hapi-16-plugin.

cianfoley-nearform commented 6 years ago

Looks good to me Paolo!