nearform / udaru

Open source Access Manager for node.js

https://nearform.github.io/udaru

MIT License

124 stars 19 forks source link

Refactored hooks. Fixes #513. #514

Closed ShogunPanda closed 6 years ago

ShogunPanda commented 6 years ago

I refactored hooks implementation following @mcollina hints in #513. I also renamed the addHook/clearHook methods to hooks.add and hooks.clear to be consistent with the rest of udaru.

coveralls commented 6 years ago

Coverage decreased (-0.003%) to 93.133% when pulling 24313c8befa733deda15650c7b3427975a839b59 on hooks-refactoring into eb10745e98d5bdcaabd3b3900ecce647bb8e6fb0 on master.

ShogunPanda commented 6 years ago

DO NOT MERGE

After talking with @mcollina (thanks a lot) I realized my implementation is overly complicated. This PR will be updated soon.

ShogunPanda commented 6 years ago

@mcollina I've rebased my branch on master, but I've implemented all the changes you requested. Can you please look at again?