search

nearform / udaru

Open source Access Manager for node.js
https://nearform.github.io/udaru
MIT License
124 stars 19 forks source link

Merge swagger and validation #536

Closed cianfoley-nearform closed 6 years ago

cianfoley-nearform commented 6 years ago

please reference the third commit, i branched this from https://github.com/nearform/udaru/pull/535

Swagger.js was replicatd in hapi-16 and 17 plugins so I merged with validation in core and added a swagger object to the modules export and am using that in place. Swagger.js files subsequently deleted in both modules (they both already referenced core validation specific objects, so I replaced the swagger ref with reference to new swagger object in validation. We could rename it 'output', and combine the existing validation objects into an 'input' object too for further clarity.

There are probably some input and output sub objects that can could be merged if identical, which should be ongoing refactoring task.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.2%) to 93.182% when pulling 65a9d1ccb0f570ede46eaac936e906faace2140f on merge-swagger-and-validation into 36aec3a233990c8adb5aa85f9a94187f5afac1d3 on master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.2%) to 93.182% when pulling 061c710ed6920d02ffe3b2e730127e6de984e9f3 on merge-swagger-and-validation into 363faeec11229208cc6ae5e7c2f6de8b1aec416c on master.