Organization & teams create callback handling

nearform / udaru

Open source Access Manager for node.js

https://nearform.github.io/udaru

MIT License

124 stars 19 forks source link

Organization & teams create callback handling #560

Closed allbto closed 5 years ago

allbto commented 5 years ago

Hi @mihaidma

Just a small PR for Udaru. I had a small issue where calling:

await udaru.organizations.create(organization, { createOnly: true })

would ignore my 2 param { createOnly: true }.

My current working workaround is:

await udaru.organizations.create(organization, { createOnly: true }, true)

to skip the missing callback check.

But I thought I would contribute back to fix this small issue. Let me know if you have any question.

coveralls commented 5 years ago

Coverage increased (+0.005%) to 93.153% when pulling dc3dc9314f49a47c520657c413b2a6738567d470 on allbto:hotfix/create-resources-callback into b18963b31632650744aa6cfa802f6fa42818712d on nearform:master.

mihaidma commented 5 years ago

Thank you @allbto for the contribution, looks good. Sorry for the late reply. Will merge it and start preparing a release