search

nearmap / kcd

Continuous Delivery for Kubernetes
MIT License
72 stars 7 forks source link

Deployment fails when number of pods is 0 #50

Closed svrana closed 5 years ago

svrana commented 5 years ago

Background: I've got a multi-cluster setup where the configurations for each cluster are generated with a template. To prevent applications from running in certain clusters, I set the number of replicas in the app's Deployment to 0 for that cluster.

The kcd syncer is still started for these applications and deploys are triggered, but the deploys fails in the clusters with 0 pods, b/c the checkPods() method checks that the number of pods is greater than 1.

Having CheckPods() return success in the 0 pod case works fine for now, though I wonder if it might make sense to not start the syncers at all in the 0 pod case?

svrana commented 5 years ago

I was able to change our configuration so as not to configure kcd in clusters where the apps will not be deployed, so I can do this without this. The way it is now is probably a good default.