Closed Ankcorn closed 3 years ago
@all-contributors please add @Ankcorn for code
@ceilfors
I've put up a pull request to add @Ankcorn! :tada:
Hey @Ankcorn. Thanks for raising this PR. This change looks good. Would you mind removing all of the package.json changes so that I can merge this? The package versioning is currently managed by lerna
, therefore it'll be automatically bumped in the release.
I'll be away, for finally a holiday, in the next 2 weeks, so I won't be able to merge this as quickly you'd expect.
@laconiajs/maintainers I'm not sure if any of you are still active, if you are feel free to help merge this one :)
Thanks @ceilfors I have reverted those package.json changes. Have a great holiday.
@Ankcorn It'll probably be easier for me to merge if you remove the commit for package-lock.json as well, it's a bit hard to review these auto-generated files.
Optionally it'll be great if you can make the CI test pass. I think there's a missing test for createS3EventAdapter. Getting there!
Can't seem to get the acceptance test package-lock dif to go away. But have added that test. I probably should have kept my install in an individual commit.
@Ankcorn Released under v1.12.0. Thanks! Would you be interested to update our docs as well? https://github.com/laconiajs/website
Thanks, Yeah of course :)
I have the requirement to parse a file that is not JSON but doesn't want to use streams as the file is never exceptionally large.
You would use this text adaptor by doing this