search

neat-php / object

Neat Object components
MIT License
4 stars 1 forks source link

Throw a RuntimeException when no manager was initialized. #17

Closed annavanbiemen closed 4 years ago

annavanbiemen commented 4 years ago

When using the Manager::instance() method without initializing it properly, you'll get the following notice:

PHP Notice: Undefined index: default in .../vendor/neat/object/classes/Manager.php on line 89

Followed by a fatal error:

PHP Fatal error: Uncaught TypeError: Return value of Shopbox\\System\\Model\\Config::manager() must be an instance of Neat\\Object\\Manager, null returned

A RuntimeException would be better.

annavanbiemen commented 4 years ago

Was fixed in 6789982059db5c817849b15bc987f9b102cbb59c