search

neatchee / mastodon

A glitchy but lovable microblogging server
https://glitch-soc.github.io/docs/
GNU Affero General Public License v3.0
15 stars 7 forks source link

Boosts are only inserted into the public timelines on page refresh #21

Open neatchee opened 1 year ago

neatchee commented 1 year ago

Steps to reproduce the problem

  1. Enable the glitch-soc "show boosts in local timelines" feature
  2. On account A, make a post
  3. On account A, pull up the Local timeline
  4. In a separate browser session, on account B, boost the post from account A
  5. Do not refresh the page

Expected behaviour

Post appears in local timeline immediately when posted, and boost also appears immediately when boosted

Actual behaviour

Post appears in local timeline immediately when posted, but boost does not appear until the page is refreshed

Detailed description

Pretty straight-forward: posts are automatically inserted into the local timeline without a refresh, but boosts (and probably replies?) are not

Specifications

N/A - just build from neatchee/main

deanveloper commented 1 year ago

It looks like replies work fine, but boosts don't. Does this even work in glitch-soc? The broadcast_to_public_streams method (which i think is the only place that we redis.publish to timeline:public:...) never gets called on boosts, and I don't think I changed any logic on when that method gets called. I'll see what I can do to get boosts displaying over pubsub.