search

neatnik / omg.lol

Cool stuff for omg.lol
MIT License
359 stars 50 forks source link

[Bug] Address name works in Account API #592

Open wayneyaoo opened 1 year ago

wayneyaoo commented 1 year ago

Bug Description

I'm not completely sure if these two API should work (but they actually work).

https://api.omg.lol/account/wy-test/addresses
https://api.omg.lol/account/wy-test/sessions

because the accont/{stuff} is supposed to be an email address, not an address inside the account.

Given this

https://api.omg.lol/account/wy-test/info

and this

https://api.omg.lol/account/wy-test/name

don't work, the above two should not work right?

I understand there's nuance between the modeling of "account" and "address" and they're ever changing. Totally fine if we have a clear definition of both and correct reflection in API in the later overhaul.

Steps to Reproduce

No response

ejstreet commented 1 year ago

Is this a bug, or a feature? :) Should be documented though if the latter

wayneyaoo commented 1 year ago

Is this a bug, or a feature? :) Should be documented though if the latter

seems to a bug but let's wait for adam's confirmation.. since wy-test is not an email address, and not following the pattern