added sorting to sharing dropdown

kildre commented 2 months ago

Added sorting to the sharing element of the form

Reference Issues or PRs

What does this implement/fix?

Fixes the randomness of users in the drop down, now alphabetized Put a x in the boxes that apply

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds a feature)
[ ] Breaking change (fix or feature that would cause existing features not to work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] Other (please describe):

Testing

[x] Did you test the pull request locally?
[x] Did you add new tests?

Documentation

Access-centered content checklist

Text styling

[ ] The content is written with plain language (where relevant).
[ ] If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
[ ] All links describe where they link to (for example, check the Nebari website).
[ ] This content adheres to the Nebari style guides.

Non-text content

[ ] All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
[ ] If there are emojis, there are not more than three in a row.
[ ] Don't use flashing GIFs or videos.
[ ] If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
jhub-apps	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 3, 2024 1:56pm
jhub-apps-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 3, 2024 1:56pm

kildre commented 2 months ago

I think you'll need to clean this up as well, with this change:

https://github.com/nebari-dev/jhub-apps/blob/9ea8204d1f678fd789de6453d7622d6a02195de4/ui/src/components/app-sharing/app-sharing.tsx#L246

All's good following conversation.

nebari-dev / jhub-apps

added sorting to sharing dropdown #473