Favicon missing on Create App pages - Githubissues

nebari-dev / jhub-apps

Application creator and general launcher for JupyterHub

https://jhub-apps.nebari.dev/

BSD 3-Clause "New" or "Revised" License

27 stars 12 forks source link

Favicon missing on Create App pages #479

Closed jbouder closed 2 months ago

jbouder commented 2 months ago

Reference Issues or PRs

Fixes #477

What does this implement/fix?

Put a x in the boxes that apply

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds a feature)
[ ] Breaking change (fix or feature that would cause existing features not to work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] Other (please describe):

Testing

[x] Did you test the pull request locally?
[ ] Did you add new tests?

Screenshots

Screenshot 2024-09-13 at 3 34 27 PM

Any other comments?

Updated japps custom page template to provide hub_title and favicon based on app configs, to match those used in the base page template.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
jhub-apps	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 13, 2024 7:39pm
jhub-apps-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 13, 2024 7:39pm