Handle Redirection or Navigation Post App Deployment in JupyterLab iframe

jbouder commented 2 weeks ago

Reference Issues or PRs

Fixes #508

What does this implement/fix?

Put a x in the boxes that apply

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds a feature)
[ ] Breaking change (fix or feature that would cause existing features not to work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] Other (please describe):

Testing

[x] Did you test the pull request locally?
[x] Did you add new tests?

Screenshots

Any other comments?

Added new success page with link to open app in new tab
Updated applicable pages to direct to this page when headless

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
jhub-apps	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 1, 2024 5:28pm
jhub-apps-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 1, 2024 5:28pm

nenb commented 2 weeks ago

@jbouder This looks great! The only thing I noticed locally is that when I click on the Deploy App button, it redirects to the bottom of the success page - I then have to scroll up to see the message (see the attached GIF). As it's largely a blank screen, this can be a little confusing for users.

Is it possible/in scope to redirect to the top of the success page?

output

nenb commented 2 weeks ago

Confirmed that this is now working locally. Thanks @jbouder!

nebari-dev / jhub-apps