nebari-dev / jhub-apps

Application creator and general launcher for JupyterHub
https://jhub-apps.nebari.dev/
BSD 3-Clause "New" or "Revised" License
27 stars 12 forks source link

[ENH] Send server owner when starting shared server #529

Closed aktech closed 1 day ago

aktech commented 1 week ago

Context

When starting a shared server, by the user who is not the owner of that server, we're currently only sending the server name to the API call: POST /server/<server-name>,

We should send server owner as well, probably as a query param: POST /server/<server-name>?owner=username

This information is already available in the frontend in the url of the app, for example: https://<HUB-URL>/hub/user/<USERNAME>/server-name/

Value and/or benefit

This was not a problem until now as the server names were unique across the system due to the appended 6 character suffix in the server name.

We're now implementing deterministic server url here: https://github.com/nebari-dev/jhub-apps/issues/475 Which would mean the server name would not be unique across the system and knowing who owns the server is important to be able to start the right server.

Anything else?

No response

aktech commented 1 day ago

Fixed in #533