Fix defaults for optionals, remove placeholder exhibits, do not add section if empty - Githubissues

nebari-dev / jupyterlab-gallery

A JupyterLab gallery for presenting and downloading examples

BSD 3-Clause "New" or "Revised" License

3 stars 1 forks source link

Fix defaults for optionals, remove placeholder exhibits, do not add section if empty #19

Closed krassowski closed 2 months ago

krassowski commented 2 months ago

Reference Issues or PRs

not-failing on optional value being None is needed for https://github.com/nebari-dev/nebari/pull/2501
not adding a section to launcher if no exhibits are configured is a short-term solution for https://github.com/nebari-dev/jupyterlab-gallery/issues/18

What does this implement/fix?

Put a x in the boxes that apply

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds a feature)
[ ] Breaking change (fix or feature that would cause existing features not to work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] Other (please describe):

Testing

[x] Did you test the pull request locally?
[ ] Did you add new tests?

github-actions[bot] commented 2 months ago

:point_left: Launch a Binder on branch nebari-dev/jupyterlab-gallery/fix-defaults